[SR-2694] Cannot JSON serialize array with boolean value #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiHemak
changed the title
phausler
requested changes
Sep 19, 2016
| @@ -285,6 +285,8 @@ private struct JSONWriter { | |||
| try serializeDictionary(dict) | |||
| } else if let null = obj as? NSNull { | |||
| try serializeNull(null) | |||
| } else if let boolVal = obj as? Bool { | |||
| try serializeNumber(NSNumber(booleanLiteral: boolVal)) | |||
There was a problem hiding this comment.
NSNumber(value: boolVal) would be better since you are not passing a literal here
saiHemak
force-pushed
the
jsonserialize-branch
branch
from
1e6d34c to
47790e1
Compare
|
@phausler ..Thanks for the review..I have modified the code as per your comments .Please review |
pushkarnk
reviewed
Sep 27, 2016
| func test_booleanJSONObject() { | ||
| do { | ||
| let mydata = try JSONSerialization.data(withJSONObject: [true]) | ||
| XCTAssertEqual(String(data: mydata, encoding: String.Encoding.utf8),"[1]") |
There was a problem hiding this comment.
nit: missing whitespace between arguments
saiHemak
force-pushed
the
jsonserialize-branch
branch
from
47790e1 to
68d703e
Compare
|
@swift-ci please test |
|
@phausler if you're ok with this after the changes, please merge |
pushkarnk
pushed a commit
to pushkarnk/swift-corelibs-foundation
that referenced
this pull request
Oct 7, 2016
parkera
pushed a commit
that referenced
this pull request
Oct 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.swift.org/browse/SR-2694